mchades commented on code in PR #12603:
URL: https://github.com/apache/gravitino/pull/12603#discussion_r4118832241
##########
core/src/main/java/org/apache/gravitino/storage/relational/mapper/provider/DefaultMapperPackageProvider.java:
##########
@@ -83,9 +83,9 @@ public List<Class<?>> getMapperClasses() {
PolicyVersionMapper.class,
RoleMetaMapper.class,
SchemaMetaMapper.class,
- SecurableObjectMapper.class,
SemanticModelMetaMapper.class,
SemanticModelVersionInfoMapper.class,
+ SecurableObjectMapper.class,
Review Comment:
This was accidental. I restored SecurableObjectMapper to its original
alphabetical position in 468028ab53.
##########
core/src/main/java/org/apache/gravitino/storage/relational/service/SemanticModelPOStorageOps.java:
##########
@@ -80,6 +88,38 @@ public SemanticModelPO getPOByFullName(
return po;
}
+ @Override
+ public List<SemanticModelPO> listPOs(SemanticModelMetaMapper mapper, Long
parentId) {
+ return mapper.listSemanticModelPOsBySchemaId(parentId);
+ }
+
+ @Override
+ public List<SemanticModelPO> listPOs(
+ SemanticModelMetaMapper mapper, List<Long> semanticModelIds) {
+ return mapper.listSemanticModelPOsBySemanticModelIds(semanticModelIds);
Review Comment:
Removed the unused ID-list override and the corresponding mapper and SQL
provider methods in 468028ab53. The path can be added together with its
MetadataObjectService consumer when the Semantic Model securable-object
integration lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
