yuqi1129 commented on PR #13484: URL: https://github.com/apache/gravitino/pull/13484#issuecomment-5873006409
Thanks for the review @jerryshao. All inline comments are addressed in 09d345cc77. About `insertFilesetMetaOnDuplicateKeyUpdate` from the summary: agreed, I removed it. That covers the mapper method, the factory method, both provider implementations and their two SQL tests. It had no production caller, so there is no longer a question about what its `current_version` should mean. I also fixed a Javadoc in `selectFilesetMetaBySchemaIdAndNameForUpdate` that still talked about the upsert. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
