lasdf1234 commented on code in PR #13539:
URL: https://github.com/apache/gravitino/pull/13539#discussion_r4120620435


##########
core/src/main/java/org/apache/gravitino/cloud/storage/S3PropertiesMetadata.java:
##########
@@ -38,7 +38,7 @@ public class S3PropertiesMetadata {
                   "S3 access key ID",
                   false /* immutable */,
                   null /* defaultValue */,
-                  false /* hidden */))
+                  true /* hidden */))

Review Comment:
   Done. Added notes on docs/fileset-catalog-with-s3.md, 
fileset-catalog-with-oss.md, and fileset-catalog-with-cos.md that load/list 
returns ****** for the static credential keys, and that plaintext is recovered 
via getCredentials (other non-credential secrets via getSecrets), consistent 
with the Glue / fileset catalog pages.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to