mchades commented on code in PR #12626:
URL: https://github.com/apache/gravitino/pull/12626#discussion_r4123064413


##########
server/src/main/java/org/apache/gravitino/server/web/rest/SemanticModelOperations.java:
##########
@@ -157,4 +204,103 @@ public Response loadSemanticModel(
           OperationType.LOAD, semanticModel, schema, e);
     }
   }
+
+  /**
+   * Alters a Semantic Model atomically.
+   *
+   * @param metalake The metalake name.
+   * @param catalog The catalog name.
+   * @param schema The schema name.
+   * @param semanticModel The current Semantic Model name.
+   * @param request The updates to apply.
+   * @return A response containing the altered Semantic Model.
+   */
+  @PUT
+  @Path("{semanticModel}")
+  @Produces("application/vnd.gravitino.v1+json")
+  @Timed(name = "alter-semantic-model." + MetricNames.HTTP_PROCESS_DURATION, 
absolute = true)
+  @ResponseMetered(name = "alter-semantic-model", absolute = true)
+  public Response alterSemanticModel(

Review Comment:
   Authorization for alter and drop is outside the scope of this PR and is 
tracked in #12594. After incorporating this PR, #13512 will apply 
`MODIFY_SEMANTIC_MODEL_AUTHORIZATION_EXPRESSION` to alter and the separate 
`DROP_SEMANTIC_MODEL_AUTHORIZATION_EXPRESSION` to drop, with the required 
authorization metadata.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to