lasdf1234 commented on code in PR #13468:
URL: https://github.com/apache/gravitino/pull/13468#discussion_r4119078817
##########
core/src/main/java/org/apache/gravitino/job/JobManager.java:
##########
@@ -508,6 +501,10 @@ public JobEntity runJob(String metalake, String
jobTemplateName, Map<String, Str
// Check if the job template exists, will throw NoSuchJobTemplateException
if it does not exist.
JobTemplateEntity jobTemplateEntity = getJobTemplate(metalake,
jobTemplateName);
+ // Reject a job with missing parameters before creating anything for it.
+ JobTemplateResolver jobTemplateResolver = new
JobTemplateResolver(jobTemplateEntity);
+ jobTemplateResolver.checkJobConf(jobConf);
Review Comment:
**Looks good:** rejecting missing parameters via `checkJobConf()` before
`Files.createDirectories()` matches the PR goal — failed runs leave no staging
artifacts. `testRunJobRejectsMissingParametersBeforeStaging` covers this path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
