Copilot commented on code in PR #13524:
URL: https://github.com/apache/gravitino/pull/13524#discussion_r4115260057


##########
core/src/main/java/org/apache/gravitino/authorization/UserGroupManager.java:
##########
@@ -65,6 +65,7 @@ protected UserGroupManager(EntityStore store, IdGenerator 
idGenerator) {
   }
 
   User addUser(String metalake, String name) throws UserAlreadyExistsException 
{
+    MetalakeManager.checkMetalake(NameIdentifier.of(metalake), store);

Review Comment:
   The new guard also changes the result for an existing but disabled metalake 
to `MetalakeNotInUseException`, but this regression test covers only the 
missing-metalake branch. Please add coverage for all four operations after 
disabling a fixture metalake so both outcomes of the new validation are 
protected.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to