mchades commented on issue #12594: URL: https://github.com/apache/gravitino/issues/12594#issuecomment-5834225530
Recording a remaining part of this issue's authorization scope. During [#12831 review](https://github.com/apache/gravitino/pull/12831#discussion_r4089149729), catalog-backed source validation was removed from Core. The accepted resolution deferred source existence, referenced-column, and authorization checks to #12594's caller-facing layer because internal dispatcher lookups do not enforce caller authorization and may expose inaccessible metadata. The remaining work should: - Add `SemanticModelOperations` to `GravitinoInterceptionService` and apply authorization annotations after #12625 lands. - Add a reusable server-side `SemanticModelSourceValidator`, called by create and later shared with `replaceDefinition`. - Authorize source visibility before resolving each Table/View when authorization is enabled. - Always validate source existence and referenced columns, including when authorization is disabled. The source validator must run unconditionally. With authorization disabled, the authorization step should pass through while existence and column validation continue. Expected error behavior remains `403` for authorization failures, `400` for missing sources or referenced columns, and `502` for source catalog connection failures. #12867 currently covers the Semantic Model privilege, ownership, and authorization-expression foundation. The caller-facing source validation and REST wiring remain to be completed under this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
