bharos commented on PR #12757: URL: https://github.com/apache/gravitino/pull/12757#issuecomment-5826722055
> Hi @bharos , thanks a lot for your proposal. Here are several open questions: > > 1. How to deal with privileges defined both with RBAC and TBAC? Which takes precedence, and how do we handle conflicts? > 2. Tags have inheritance, and our RBAC system has inheritance too (SELECT TABLE on the catalog will automatically inherit the privileges). Will these two inheritance models conflict? Will this increase the complexity of calculating the privileges when authorizing? Thanks for the review @jerryshao 1 & 2 are answered among your above comments. Basically, RBAC and TBAC evaluation will be a union of permissions from (allowed_rbac || allowed_tbac) && !deny_rbac Inheritance also should be fine, as for tag-based evaluation as well, we walk up the ancestoral chain and collect the tags and finally union it. > 3. Will this TBAC bring in any privilege leakage issue or any unexpected corner case? For this, maybe you can take a look at the open questions section (those have now been answered with proposed approaches). Overall those are the more sensitive areas I could think of , and I hope they are handled by the choices made in that section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
