Copilot commented on code in PR #12625: URL: https://github.com/apache/gravitino/pull/12625#discussion_r4095110149
########## server/src/main/java/org/apache/gravitino/server/web/rest/SemanticModelOperations.java: ########## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.server.web.rest; + +import com.codahale.metrics.annotation.ResponseMetered; +import com.codahale.metrics.annotation.Timed; +import javax.inject.Inject; +import javax.servlet.http.HttpServletRequest; +import javax.ws.rs.GET; +import javax.ws.rs.POST; +import javax.ws.rs.Path; +import javax.ws.rs.PathParam; +import javax.ws.rs.Produces; +import javax.ws.rs.core.Context; +import javax.ws.rs.core.Response; +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.catalog.SemanticModelDispatcher; +import org.apache.gravitino.dto.requests.SemanticModelCreateRequest; +import org.apache.gravitino.dto.responses.SemanticModelResponse; +import org.apache.gravitino.dto.util.DTOConverters; +import org.apache.gravitino.metrics.MetricNames; +import org.apache.gravitino.semantic.SemanticModel; +import org.apache.gravitino.server.web.Utils; +import org.apache.gravitino.utils.NameIdentifierUtil; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** REST create and load operations for schema-scoped Semantic Models. */ +@Path("metalakes/{metalake}/catalogs/{catalog}/schemas/{schema}/semantic-models") Review Comment: This new resource is not covered by the server's authorization interceptor: `GravitinoInterceptionService.getDescriptorFilter()` has an explicit allowlist that does not include `SemanticModelOperations`, and neither endpoint declares `@AuthorizationExpression`/`@AuthorizationMetadata`. With authorization enabled, these requests bypass the metadata authorization checks applied to tables, views, and functions, allowing callers without the required privileges to create or load Semantic Models. Add this resource to the interceptor allowlist and apply the appropriate schema/model authorization expressions and parameter metadata (or enforce equivalent checks) before exposing it. This issue also appears in the following locations of the same file: - line 73 - line 120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
