LuciferYang commented on code in PR #13440:
URL: https://github.com/apache/gravitino/pull/13440#discussion_r4092856879
##########
core/src/main/java/org/apache/gravitino/secret/SecretManager.java:
##########
@@ -384,7 +394,8 @@ public String alterSetSecretBinding(
long entityId,
String property,
SecretBinding binding,
- List<SecretMaterial> written) {
+ List<SecretMaterial> written,
+ List<SecretUrn> replacedUrns) {
Review Comment:
These are internal `SecretManager` methods (both `SecretManager` and their
only caller `SecretAlterChanges` live in `org.apache.gravitino.secret` in
core), and every caller is updated in this PR. `SecretManager` is
server-internal, not a published client API, so there is no external caller to
break; the new `replacedUrns` parameter is what carries the deferred-delete
collection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
