yuqi1129 commented on code in PR #12747:
URL: https://github.com/apache/gravitino/pull/12747#discussion_r4083137947
##########
catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/converter/DorisColumnDefaultValueConverter.java:
##########
@@ -88,6 +89,46 @@ public String fromGravitinoForAddColumn(
return super.fromGravitino(defaultValue);
}
+ /**
+ * Converts a loaded default value for a Doris MODIFY COLUMN definition.
+ *
+ * <p>String literals containing quote or backslash characters need
Doris-specific escaping.
+ * Unparsed expressions come from native Doris metadata and are passed
through unchanged.
+ *
+ * @param defaultValue the loaded Gravitino default value
+ * @param doubleEscapeBackslashes whether Doris 3.x requires an additional
backslash-escaping
+ * layer
+ * @param tripleEscapeQuotes whether Doris 3.x MODIFY COLUMN requires three
backslashes before an
+ * embedded double quote
+ * @return the Doris SQL representation, or {@code null} when the default is
unset
+ */
+ @Nullable
+ public String fromGravitinoForColumnDefinition(
Review Comment:
I suggest you change the name to `fromGravitinoForModifyColumn`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
