danhuawang commented on code in PR #13464: URL: https://github.com/apache/gravitino/pull/13464#discussion_r4079894165
########## dev/docker/trino-connectors/README.md: ########## @@ -181,57 +181,78 @@ configure Basic or OAuth2. In the cluster this is usually `http://{service}.{namespace}.svc.cluster.local:8090`. A published HTTPS URL works the same way; it is not tied to the auth type. +`gravitino.metalake` is optional. Omit it (or leave it empty) to load catalogs +from every metalake. Set it when you want a single metalake only. + `gravitino.client.authType` accepts `simple`, `basic`, `oauth2`, or `kerberos`. The OAuth2 token path key is `gravitino.client.oauth2.path`. ### Basic +On a multi-node Trino cluster, also map the password to an env var (see +[Worker credentials](#worker-credentials-on-a-distributed-cluster)) and set +that env var on every pod. + ```properties connector.name=gravitino gravitino.uri=http://gravitino.example.svc.cluster.local:8090 -gravitino.metalake=test -gravitino.use-single-metalake=false +# Optional: omit gravitino.metalake to load every metalake +gravitino.use-single-metalake=true Review Comment: Good catch — fixed. Migrated the examples, properties table, and Catalog names section from deprecated `gravitino.use-single-metalake` to `gravitino.catalog-name-with-metalake` (using `true` when omitting `gravitino.metalake` so catalog names stay qualified). ########## dev/docker/trino-connectors/README.md: ########## @@ -181,57 +181,78 @@ configure Basic or OAuth2. In the cluster this is usually `http://{service}.{namespace}.svc.cluster.local:8090`. A published HTTPS URL works the same way; it is not tied to the auth type. +`gravitino.metalake` is optional. Omit it (or leave it empty) to load catalogs +from every metalake. Set it when you want a single metalake only. + `gravitino.client.authType` accepts `simple`, `basic`, `oauth2`, or `kerberos`. The OAuth2 token path key is `gravitino.client.oauth2.path`. ### Basic +On a multi-node Trino cluster, also map the password to an env var (see +[Worker credentials](#worker-credentials-on-a-distributed-cluster)) and set +that env var on every pod. + ```properties connector.name=gravitino gravitino.uri=http://gravitino.example.svc.cluster.local:8090 -gravitino.metalake=test -gravitino.use-single-metalake=false +# Optional: omit gravitino.metalake to load every metalake +gravitino.use-single-metalake=true gravitino.client.authType=basic Review Comment: Agreed. Kept `gravitino.iceberg.rest-uri` in the Basic example (that override is the common multi-node failure mode) and added `gravitino.iceberg.rest-catalog.security=NONE` so registration does not hit `GRAVITINO_MISSING_CONFIG` under default Iceberg REST routing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
