LuciferYang opened a new pull request, #13446:
URL: https://github.com/apache/gravitino/pull/13446

   ### What changes were proposed in this pull request?
   
   Add a `SEMANTIC_MODEL` case to `MetadataObjectUtil.checkMetadataObject`: 
validate the identifier with `NameIdentifierUtil.checkSemanticModel` and check 
existence via `semanticModelDispatcher().loadSemanticModel`, following the 
load-and-catch pattern of the sibling cases. It uses the public 
`semanticModelDispatcher()` because `GravitinoEnv` has no internal 
semantic-model dispatcher variant.
   
   ### Why are the changes needed?
   
   `SEMANTIC_MODEL` was the one metadata object type missing from the switch, 
so it fell through to `default` and threw `IllegalArgumentException`, making 
tag/policy association with a semantic model fail even though the type is 
otherwise supported.
   
   Fix: #13445
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Extended 
`TestMetadataObjectUtil.testCheckMetadataObjectUsesInternalDispatchers` to 
cover a `SEMANTIC_MODEL` object and assert `loadSemanticModel` is invoked. It 
fails against the pre-fix code.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to