yuqi1129 commented on code in PR #12826:
URL: https://github.com/apache/gravitino/pull/12826#discussion_r4057105629
##########
catalogs-contrib/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/operations/ClickHouseTableOperations.java:
##########
@@ -1745,6 +1751,27 @@ private List<Index> querySecondaryIndexes(
type);
continue;
}
+
+ Map<String, String> parameterProperties = Collections.emptyMap();
+ if (indexType == Index.IndexType.DATA_SKIPPING_SET) {
+ try {
+ parameterProperties =
+ parseIndexPropertiesForQuery(indexType, parameterSource,
name, !includesTypeFull);
Review Comment:
Could we parse the SET parameter after `parseIndexFields` succeeds, as we do
for the bloom-filter indexes below? For a ClickHouse SET index whose expression
Gravitino cannot represent (for example, `INDEX idx cityHash64(col) TYPE
set(2147483648)`), the old path skips the index and still loads the table. This
new early parse throws on the SET value before reaching that skip, so the
entire table load fails. ClickHouse reads the SET limit as `size_t`, so values
above `Integer.MAX_VALUE` can exist. A test combining an unsupported expression
with an out-of-range SET value would guard the existing skip behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
