jiangxt2 commented on code in PR #12772:
URL: https://github.com/apache/gravitino/pull/12772#discussion_r4046570186
##########
docs/jdbc-clickhouse-catalog.md:
##########
@@ -223,18 +228,18 @@ If you need Gravitino to manage an existing cluster
database or table, recreate
**Memory engine data volatility**: Tables created with `engine=Memory` store
data in RAM only. After a ClickHouse server restart the table definition
persists (Gravitino's `loadTable` succeeds), but all data is permanently lost.
Gravitino metadata and ClickHouse remain consistent at the schema level, but
users are responsible for repopulating data after restarts. Consider using
`TinyLog`, `StripeLog`, or a MergeTree-family engine if data durability is
required.
:::
-| Property Name | Description
| Default Value |
Required | Reserved | Immutable |
-|---------------------------|----------------------------------------------------------------------------------------------------------|---------------|------------|----------|-----------|
-| `engine` | Table engine (for example `MergeTree`,
`ReplacingMergeTree`, `Distributed`, `Memory`, etc.) | `MergeTree`
| No | No | Yes |
-| `graphite.config` | Name of the `<graphite_rollup>` configuration
element used by `GraphiteMergeTree` | (none) |
No\*\*\* | No | No |
-| `engine_parameters` | Parameters for supported parameterized MergeTree
engines | (none) | No
| No | No |
-| `cluster-name` | Cluster name used with `ON CLUSTER` and
Distributed engine | (none)
| No\* | No | No |
-| `on-cluster` | Use `ON CLUSTER` when creating the table
| (none) | No
| No | No |
-| `cluster-remote-database` | Remote database for `Distributed` engine
| (none) |
No\*\* | No | No |
-| `cluster-remote-table` | Remote table for `Distributed` engine
| (none) |
No\*\* | No | No |
-| `cluster-sharding-key` | Sharding key for `Distributed` engine
(expression allowed; referenced columns must be non-null integral) | (none)
| No\*\* | No | No |
-| `settings.<name>` | ClickHouse engine setting forwarded as `SETTINGS
<name>=<value>` | (none) | No
| No | No |
-| `partition-key` | ClickHouse's canonical native partition
expression (from `system.tables.partition_key`). Read-only; always present on
load, empty string means unpartitioned. | `""` | No | Yes
| Yes |
+| Property Name | Description
| Default Value |
Required | Reserved | Immutable |
+|---------------------------|----------------------------------------------------------------------------------------------------------|---------------|----------|----------|-----------|
+| `engine` | Table engine (for example `MergeTree`,
`ReplacingMergeTree`, `Distributed`, `Memory`, etc.) | `MergeTree`
| No | No | Yes |
+| `graphite.config` | Name of the `<graphite_rollup>` configuration
element used by `GraphiteMergeTree` | (none) |
No\*\*\* | No | No |
+| `engine_parameters` | Parameters for supported parameterized MergeTree
engines | (none) | No
| No | No |
+| `cluster-name` | Cluster name used with `ON CLUSTER` and
Distributed engine | (none)
| No\* | No | No |
+| `on-cluster` | Use `ON CLUSTER` when creating the table
| (none) | No
| No | No |
+| `cluster-remote-database` | Remote database for `Distributed` engine
| (none) |
No\*\* | No | No |
Review Comment:
OK. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
