Copilot commented on code in PR #13195:
URL: https://github.com/apache/gravitino/pull/13195#discussion_r4021969390
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/CatalogConnectorContext.java:
##########
@@ -58,18 +60,22 @@ public class CatalogConnectorContext {
* @param catalog the Gravitino catalog
* @param metalake the Gravitino metalake
* @param internalConnector the internal connector
+ * @param internalConnectorConfig the effective configuration used to create
the internal
+ * connector
* @param adapter the catalog connector adapter
* @param config the Gravitino connector configuration
*/
public CatalogConnectorContext(
GravitinoCatalog catalog,
GravitinoMetalake metalake,
Connector internalConnector,
+ Map<String, String> internalConnectorConfig,
Review Comment:
Changing this public constructor to require `internalConnectorConfig`
removes the existing six-argument JVM descriptor, so custom connector
integrations compiled against the released class will fail with
`NoSuchMethodError` (and source consumers will no longer compile). Please
retain a six-argument overload that delegates to the new constructor; using an
empty config preserves the previous eager-metadata behavior for legacy callers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
