laserninja opened a new pull request, #13163:
URL: https://github.com/apache/gravitino/pull/13163

   ### What changes were proposed in this pull request?
   
   Return an external type preserving precision and scale when a constrained 
PostgreSQL NUMERIC cannot be represented by Gravitino DecimalType. Decode 
unsigned JDBC negative-scale metadata and retain supported decimal mappings. 
Add converter and catalog integration tests and update the mapping 
documentation.
   
   ### Why are the changes needed?
   
   Valid NUMERIC(39,0), NUMERIC(2,-3), and NUMERIC(3,5) columns currently 
prevent table loading because their precision or scale exceeds DecimalType 
limits.
   
   Fixes #13160
   
   ### Does this PR introduce _any_ user-facing change?
   
   Previously failing constrained NUMERIC columns load as external types such 
as numeric(39,0), numeric(2,-3), and numeric(3,5). Supported decimals and 
unconstrained NUMERIC keep their existing mappings.
   
   ### How was this patch tested?
   
   `JAVA_HOME=<JDK17> ./gradlew :catalogs:catalog-jdbc-postgresql:spotlessApply 
:catalogs:catalog-jdbc-postgresql:build -PskipITs --max-workers=2` passed (47 
tests). The new converter test failed before the fix. Live PostgreSQL 18 table 
operations returned all three exact external declarations and preserved 
decimal(10,2). Catalog integration tests compiled, including PostgreSQL 15+ 
scale cases; the full Docker integration suite was not run.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to