Copilot commented on code in PR #13048:
URL: https://github.com/apache/gravitino/pull/13048#discussion_r3987644825
##########
integration-test-common/src/test/java/org/apache/gravitino/integration/test/MiniGravitino.java:
##########
@@ -198,10 +198,12 @@ public void start() throws Exception {
executor.submit(
() -> {
try {
- GravitinoServer.main(
- new String[] {
- ITUtils.joinPath(mockConfDir.getAbsolutePath(),
"gravitino.conf")
- });
+ context
+ .serverLauncher()
+ .launch(
+ new String[] {
+ ITUtils.joinPath(mockConfDir.getAbsolutePath(),
"gravitino.conf")
Review Comment:
This change is not covered by the added tests:
`testContextCarriesACustomServerLauncher` calls
`context.serverLauncher().launch(...)` directly, so it would still pass if
`MiniGravitino.start()` regressed to calling `GravitinoServer.main` here. Add a
test that starts a `MiniGravitino` with a recording custom launcher and
verifies that `start()` dispatches that launcher with the generated
configuration path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
