Copilot commented on code in PR #13086:
URL: https://github.com/apache/gravitino/pull/13086#discussion_r3985807701
##########
docs/open-api/catalogs.yaml:
##########
@@ -165,7 +165,11 @@ paths:
regular catalog operations, but does not guarantee that every
object-level or mutating
operation will succeed. Fileset catalogs test all catalog-level
`location` and `location-*`
targets. Model and Generic catalogs do not support connection testing.
Expected test
- failures are returned as application error codes in an HTTP 200
response.
+ failures are returned as application error codes in an HTTP 200
response. When
+ authorization is enabled, testing with the stored configuration
requires the same access
+ as loading the catalog, and testing with proposed changes requires
owning the metalake or
+ the catalog, the same as altering it. Callers without that access
receive an HTTP 403
+ response.
Review Comment:
This description now promises an HTTP 403 for authorization failures, but
the operation's `responses` map below still declares only 200, 400, and 5xx.
OpenAPI consumers will not discover the new status or its error payload; add an
explicit 403 response (using the ErrorModel) to keep the contract consistent
with the implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
