diqiu50 commented on code in PR #13078: URL: https://github.com/apache/gravitino/pull/13078#discussion_r3977977200
########## docs/trino-connector/catalog-iceberg.md: ########## @@ -111,10 +111,17 @@ Four keys are reserved: `iceberg.rest-catalog.uri`, `.warehouse`, `.prefix` and `gravitino.iceberg.rest-catalog.` or a catalog's `trino.bypass.` has no effect — the connector logs when it ignores one. -When `gravitino.client.session.forwardUser=true`, the connector also sets -`iceberg.rest-catalog.session=USER` so that each query carries the end user's identity to the IRC, -keeping per-user credential vending and per-user authorization intact. Set -`gravitino.iceberg.rest-catalog.session` explicitly to override it. See +The connector sets `iceberg.rest-catalog.session=USER` automatically when both hold: + +- `gravitino.client.session.forwardUser=true` +- the IRC authenticates with OAuth2 — either `gravitino.client.authType=oauth2`, or + `gravitino.iceberg.rest-catalog.security=OAUTH2` (or `trino.bypass.iceberg.rest-catalog.security` Review Comment: They are two different properties, each written with its own convention: - `gravitino.client.authType` is a Gravitino setting, documented lowercase (`simple`, `basic`, `oauth2`, `kerberos`) — the same casing `GravitinoAuthProvider.parseAuthType` uses in its error message, and the casing used in 26 places across the docs. - `iceberg.rest-catalog.security` is a Trino enum (`NONE`, `OAUTH2`, `SIGV4`), documented uppercase upstream. Both are parsed case-insensitively, so either casing works; the docs follow each upstream's convention so the values match what a reader finds there. The real problem was that a single sentence made them read as one value written two ways. I split the three sources onto separate lines in 4f319dca6. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
