jiangxt2 opened a new pull request, #13030:
URL: https://github.com/apache/gravitino/pull/13030

   ### What changes were proposed in this pull request?
   
   Update the Lance Spark integration guide to use 
`org.lance.spark.LanceNamespaceSparkCatalog`, which is the Catalog 
implementation shipped by the supported `lance-spark-bundle-3.5_2.12:0.4.0` 
bundle.
   
   Add `checkLanceSparkCatalogDocumentation` to the Lance REST server Gradle 
build. The check extracts the Catalog class from the documentation example, 
verifies that exactly one class is documented, and checks that the 
corresponding `.class` entry exists in every prepared Lance Spark bundle. The 
check is attached to the normal `test` task and the existing 
`lanceSparkMatrixTest` task.
   
   ### Why are the changes needed?
   
   The integration guide referenced 
`com.lancedb.lance.spark.LanceNamespaceSparkCatalog`, which is absent from the 
supported 0.4.0 bundle. Following the guide fails with `ClassNotFoundException` 
while Spark loads the Catalog, before Spark contacts the Gravitino Lance REST 
endpoint. The existing `LanceSparkRESTServiceIT` already uses the correct 
`org.lance` class, so this change aligns the documentation with the runtime 
test configuration and adds a guard against future documentation-to-bundle 
drift.
   
   Fix: #13029
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Users following the Lance Spark integration guide can load the 
documented Catalog with the supported 0.4.0 bundle. No public API, REST 
protocol, storage configuration, Docker default, or vector computation behavior 
is changed.
   
   ### How was this patch tested?
   
   - `./gradlew :lance:lance-rest-server:checkLanceSparkCatalogDocumentation 
-PskipWeb=true -PskipDockerTests=true --no-daemon --console=plain`: passed for 
the default 0.4.0 bundle.
   - `./gradlew :lance:lance-rest-server:checkLanceSparkCatalogDocumentation 
-PlanceSparkBundleVersions=0.2.0,0.4.0 -PskipWeb=true -PskipDockerTests=true 
--no-daemon --console=plain`: passed for both configured bundles.
   - `./gradlew :lance:lance-rest-server:test -PskipITs -PskipDockerTests=true 
-PskipWeb=true --no-daemon --console=plain`: passed; the normal test task 
executed the documentation check.
   - `./gradlew :lance:lance-rest-server:spotlessKotlinGradleCheck 
-PskipWeb=true -PskipDockerTests=true --no-daemon --console=plain`: passed.
   - `./gradlew :lance:lance-rest-server:lanceSparkMatrixTest 
-PlanceSparkBundleVersions=0.2.0,0.4.0 -PskipDockerTests=true -PskipWeb=true 
--no-daemon --console=plain`: passed; both per-version 
`LanceSparkRESTServiceIT` tasks passed.
   
   The known 0.5.1 error-path assertion failure was not changed and did not 
gate this documentation-focused PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to