jerryshao commented on code in PR #10575:
URL: https://github.com/apache/gravitino/pull/10575#discussion_r3008099054
##########
clients/client-python/gravitino/client/relational_catalog.py:
##########
@@ -188,24 +193,96 @@ def list_tables(self, namespace: Namespace) ->
list[NameIdentifier]:
for ident in entity_list_resp.identifiers()
]
- def load_table(self, identifier: NameIdentifier) -> Table:
+ @overload
+ def load_table(self, identifier: NameIdentifier) -> Table: ...
+
+ @overload
+ def load_table( # pylint: disable=arguments-differ
+ self, identifier: NameIdentifier, required_privilege_names:
set[Privilege.Name]
+ ) -> Table: ...
+
+ def load_table(
+ self,
+ identifier: NameIdentifier,
+ required_privilege_names: Optional[set[Privilege.Name]] = None,
Review Comment:
Why do we add this `required_privilege_names` parameter? I don't find this
in the Java counterpart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
