lasdf1234 commented on code in PR #10503:
URL: https://github.com/apache/gravitino/pull/10503#discussion_r2972705807
##########
server-common/src/test/java/org/apache/gravitino/server/authentication/TestStaticSignKeyValidator.java:
##########
@@ -485,4 +485,36 @@ public void testPrincipalFieldsWithMapper() {
assertNotNull(principal);
assertEquals("john.doe", principal.getName()); // Mapper extracted local
part
}
+
+ @Test
+ public void testValidateTokenWithGroups() {
+ Map<String, String> config = createBaseConfig();
+ config.put("gravitino.authenticator.oauth.groupFields", "groups");
+ validator.initialize(createConfig(config));
+
+ // Create token with groups
+ String token =
+ Jwts.builder()
+ .setSubject("test-user")
+ .claim("groups", Arrays.asList("group1", "group2"))
+ .setAudience(serviceAudience)
+ .setIssuedAt(Date.from(Instant.now()))
+ .setExpiration(Date.from(Instant.now().plusSeconds(3600)))
+ .signWith(hmacKey, SignatureAlgorithm.HS256)
+ .compact();
+
+ Principal principal = validator.validateToken(token, serviceAudience);
+ assertNotNull(principal);
+ assertEquals("test-user", principal.getName());
+
+ // Check if principal is UserPrincipal and has groups
+ if (principal instanceof org.apache.gravitino.UserPrincipal) {
+ org.apache.gravitino.UserPrincipal userPrincipal =
+ (org.apache.gravitino.UserPrincipal) principal;
+ assertEquals(Arrays.asList("group1", "group2"),
userPrincipal.getGroups());
+ } else {
+ // This fails if the principal is not UserPrincipal or groups are missing
+ throw new AssertionError("Principal should be UserPrincipal");
Review Comment:
Got it, resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
