roryqi commented on code in PR #10052:
URL: https://github.com/apache/gravitino/pull/10052#discussion_r2964391802


##########
clients/client-java/src/main/java/org/apache/gravitino/client/GravitinoClientBase.java:
##########
@@ -356,6 +356,23 @@ public Builder<T> withClientConfig(Map<String, String> 
properties) {
       return this;
     }
 
+    /**
+     * Configures authentication based on the properties map. This method is 
called automatically in
+     * build() before creating the client instance.
+     */
+    protected void configureAuthentication() {

Review Comment:
   Could u remove this method? Because we should use create auth provider using 
API instead of properties.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to