diqiu50 commented on code in PR #10465:
URL: https://github.com/apache/gravitino/pull/10465#discussion_r2959785882
##########
catalogs/hive-metastore2-libs/build.gradle.kts:
##########
@@ -26,8 +26,35 @@ plugins {
}
dependencies {
- implementation(libs.hadoop2.common)
- implementation(libs.hive2.metastore)
+ implementation(libs.hadoop2.common) {
+ exclude(group = "org.slf4j")
+ exclude(group = "org.apache.logging.log4j")
+ exclude(group = "com.google.code.findbugs")
+ exclude(group = "org.eclipse.jetty.aggregate", module = "jetty-all")
+ exclude(group = "org.eclipse.jetty.orbit", module = "javax.servlet")
+ }
+ implementation(libs.hive2.metastore) {
+ exclude(group = "ant")
+ exclude(group = "co.cask.tephra")
+ exclude(group = "com.github.joshelser")
+ exclude(group = "com.google.code.findbugs")
+ exclude(group = "com.tdunning", module = "json")
+ exclude(group = "com.zaxxer", module = "HikariCP")
+ exclude(group = "io.dropwizard.metrics")
+ exclude(group = "javax.transaction", module = "transaction-api")
+ exclude(group = "junit")
+ exclude(group = "org.apache.ant")
+ exclude(group = "org.apache.avro")
+ exclude(group = "org.apache.hadoop", module =
"hadoop-yarn-server-resourcemanager")
+ exclude(group = "org.apache.hbase")
+ exclude(group = "org.apache.logging.log4j")
+ exclude(group = "org.apache.parquet", module = "parquet-hadoop-bundle")
+ exclude(group = "org.datanucleus")
+ exclude(group = "org.eclipse.jetty.aggregate", module = "jetty-all")
+ exclude(group = "org.eclipse.jetty.orbit", module = "javax.servlet")
+ exclude(group = "org.openjdk.jol")
+ exclude(group = "org.slf4j")
+ }
Review Comment:
Acknowledged. Extracting to a `buildSrc` convention would be the ideal
long-term solution. To keep this PR focused, we have added cross-reference
comments to both build files noting that the exclusion lists are intentionally
kept in sync, which will alert future maintainers to update both files together.
##########
catalogs/hive-metastore3-libs/build.gradle.kts:
##########
@@ -41,7 +68,28 @@ tasks {
register("copyLibs", Copy::class) {
dependsOn(copyDepends, "build")
- from("build/libs")
+ from("build/libs") {
+ exclude("guava-*.jar")
Review Comment:
Guava is provided by the Gravitino runtime classpath (this follows the same
pattern used in `catalog-hive/build.gradle.kts`). We have added a comment in
both build files documenting this assumption. We have also added `exclude(group
= "com.google.guava")` at the dependency level to be consistent with all other
excluded groups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
