Copilot commented on code in PR #10473:
URL: https://github.com/apache/gravitino/pull/10473#discussion_r2957638040
##########
web-v2/web/src/config/catalog.js:
##########
@@ -143,7 +143,7 @@ export const tableDefaultProps = {
{
key: 'format',
defaultValue: 'lance',
- disabled: true,
+ select: ['lance', 'delta'],
description: 'The format of the table'
Review Comment:
There’s no automated coverage asserting the supported `format` options for
`lakehouse-generic` (e.g., that `delta` is present). Since this config is
consumed by the create-table dialog and the repo uses Vitest, please add a
small unit test that imports `tableDefaultProps` and verifies the `format`
select list includes `delta` (and keeps `lance` as default).
##########
web-v2/web/src/config/catalog.js:
##########
@@ -143,7 +143,7 @@ export const tableDefaultProps = {
{
key: 'format',
defaultValue: 'lance',
- disabled: true,
+ select: ['lance', 'delta'],
description: 'The format of the table'
Review Comment:
This PR description/linked issue calls out “Web UI v1”, but this change only
updates web-v2. In the current web UI (web/web/src/lib/utils/initial.js), the
lakehouse-generic table `format` property is still hardcoded to `lance` and
disabled, so #10453 may remain unresolved unless that path is also updated (or
the PR clarifies that v2 is the targeted UI).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
