FANNG1 commented on code in PR #10385:
URL: https://github.com/apache/gravitino/pull/10385#discussion_r2944611731
##########
dev/release/release-build.sh:
##########
@@ -348,8 +348,8 @@ if [[ "$1" == "publish-release" ]]; then
cd ..
$GRADLE clean
- $GRADLE release -x test -PdefaultScalaVersion=2.12
- $GRADLE release -x test -PdefaultScalaVersion=2.13
+ $GRADLE assemble -PdefaultScalaVersion=2.12
+ $GRADLE assemble -PdefaultScalaVersion=2.13
Review Comment:
I prefer to keep `assemble` here as well. In `publish-release`, this step is
only a preflight to make sure the publishable artifacts can be assembled before
`publishToMavenLocal`. Using `build -x test` would broaden the scope and pull
in unrelated non-Java `build` tasks again.
##########
.github/workflows/build.yml:
##########
@@ -84,7 +84,7 @@ jobs:
- name: Build with Gradle
run: |
- ./gradlew release -x test
+ ./gradlew assemble
Review Comment:
I do not think `build -x test` is better here. `compile-check` is intended
to stay lightweight, and `build -x test` would still enter the full `build`
lifecycle for all subprojects, including non-Java build paths such as
`mcp-server`, `client-python`, and docs. `assemble` keeps this job focused on
artifact assembly/compilation only.
##########
build.gradle.kts:
##########
@@ -426,6 +405,22 @@ subprojects {
}
}
+ if (compatibleWithJDK8(project)) {
+ tasks.named<JavaCompile>("compileJava") {
+ options.release.set(8)
+ }
+
Review Comment:
Added short comments here. The key reason is that these modules still need
to publish Java 8-compatible main artifacts, while their tests must compile
against dependencies that only expose Java 17 variants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
