FANNG1 commented on PR #10424: URL: https://github.com/apache/gravitino/pull/10424#issuecomment-4071812421
@yuqi1129 Agree. This optimization does introduce extra routing logic, so there is a maintenance tradeoff. In this PR I tried to keep that complexity bounded by: - keeping everything in the existing `build` workflow instead of introducing another maintenance-specific workflow - limiting the logic to three flags with different responsibilities - renaming the flags and adding comments so the routing intent is easier to follow I also agree this is not the only possible direction. A dedicated maintenance workflow is a reasonable alternative and may be easier to understand operationally. I plan to try that approach in a separate PR so we can compare the two designs more directly: - current PR: keep one `build` workflow and optimize routing inside it - follow-up PR: split maintenance handling into a dedicated workflow and compare readability, maintenance cost, and CI behavior If the dedicated-workflow version turns out to be clearer and easier to maintain, we can switch to that direction in follow-up work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
