FANNG1 commented on code in PR #10385:
URL: https://github.com/apache/gravitino/pull/10385#discussion_r2930215877
##########
.github/workflows/build.yml:
##########
@@ -84,7 +84,7 @@ jobs:
- name: Build with Gradle
run: |
- ./gradlew release -x test
+ ./gradlew build -x test
Review Comment:
Agreed. `compile-check` is intended to stay lightweight, and `build -x test`
would expand into non-Java subproject build paths such as `mcp-server`,
`client-python`, and docs. I switched this job to `./gradlew assemble` to keep
it compile-focused.
##########
dev/release/release-build.sh:
##########
@@ -348,8 +348,8 @@ if [[ "$1" == "publish-release" ]]; then
cd ..
$GRADLE clean
- $GRADLE release -x test -PdefaultScalaVersion=2.12
- $GRADLE release -x test -PdefaultScalaVersion=2.13
+ $GRADLE build -x test -PdefaultScalaVersion=2.12
+ $GRADLE build -x test -PdefaultScalaVersion=2.13
Review Comment:
Agreed. `publish-release` only needs a pre-publish artifact assembly before
`publishToMavenLocal`, and `build -x test` was broader than the previous
`release` path. I switched the two preflight invocations to `assemble` to avoid
unrelated non-Java build steps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
