jerryshao commented on code in PR #10189:
URL: https://github.com/apache/gravitino/pull/10189#discussion_r2894026308
##########
common/src/main/java/org/apache/gravitino/dto/policy/PolicyContentDTO.java:
##########
@@ -69,4 +75,133 @@ public Map<String, String> properties() {
return properties;
}
}
+
+ /** Represents a typed iceberg compaction policy content DTO. */
+ @EqualsAndHashCode
+ @ToString
+ @Builder(setterPrefix = "with")
+ @AllArgsConstructor(access = lombok.AccessLevel.PRIVATE)
+ class IcebergCompactionContentDTO implements PolicyContentDTO {
+
+ @JsonProperty("minDataFileMse")
+ @JsonAlias("minDatafileMse")
+ private Long minDataFileMse;
+
Review Comment:
**Add a comment explaining these backward-compat aliases.**
These `@JsonAlias` entries were added when the field name was renamed from
`datafileXxx` to `dataFileXxx`. Without a comment, a future reviewer who spots
seemingly redundant aliases may remove them, breaking deserialization of
payloads from older clients.
Suggested comment:
```java
// Backward-compat alias: field was renamed from datafileMse → dataFileMse
(kebab-case unification)
@JsonAlias("minDatafileMse")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
