jerryshao commented on code in PR #10106: URL: https://github.com/apache/gravitino/pull/10106#discussion_r2889397044
########## maintenance/optimizer/src/test/java/org/apache/gravitino/maintenance/optimizer/recommender/job/TestBuiltinIcebergUpdateStatsJob.java: ########## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.maintenance.optimizer.recommender.job; + +import java.time.Duration; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.UUID; +import java.util.stream.Collectors; +import org.apache.commons.lang3.StringUtils; +import org.apache.gravitino.Catalog; +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.client.GravitinoAdminClient; +import org.apache.gravitino.client.GravitinoClient; +import org.apache.gravitino.client.GravitinoMetalake; +import org.apache.gravitino.exceptions.NoSuchMetalakeException; +import org.apache.gravitino.job.JobHandle; +import org.apache.gravitino.rel.Table; +import org.apache.gravitino.stats.Statistic; +import org.apache.spark.sql.SparkSession; +import org.awaitility.Awaitility; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.condition.EnabledIfEnvironmentVariable; + +/** Environment IT for triggering built-in Iceberg update stats job through the client API. */ +@EnabledIfEnvironmentVariable(named = "GRAVITINO_ENV_IT", matches = "true") +public class TestBuiltinIcebergUpdateStatsJob { + + private static final String SERVER_URI = "http://localhost:8090";; + private static final String ICEBERG_REST_URI = "http://localhost:9001/iceberg";; + private static final String JOB_TEMPLATE_NAME = "builtin-iceberg-update-stats"; + private static final String SPARK_CATALOG_NAME = "rest_catalog"; + private static final String WAREHOUSE_LOCATION = ""; Review Comment: Empty string for warehouse location will silently misconfigure the Spark catalog and cause Iceberg to fail at runtime. Since this is gated by `@EnabledIfEnvironmentVariable`, either derive the value from an environment variable (e.g., `System.getenv("GRAVITINO_TEST_WAREHOUSE")`) or add an explicit `Assumptions.assumeTrue(StringUtils.isNotBlank(WAREHOUSE_LOCATION))` at the start of the test so it skips rather than fails with a confusing error. ########## maintenance/optimizer-api/src/main/java/org/apache/gravitino/maintenance/optimizer/common/util/StatisticValueSerdeUtils.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.maintenance.optimizer.common.util; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.google.common.base.Preconditions; +import org.apache.gravitino.json.JsonUtils; +import org.apache.gravitino.stats.StatisticValue; + +/** Shared serde helpers for {@link StatisticValue}. */ +public final class StatisticValueSerdeUtils { + + private StatisticValueSerdeUtils() {} + + public static String toString(StatisticValue<?> value) { Review Comment: Public API methods `toString` and `fromString` lack JavaDoc. Per project standards, public APIs require JavaDoc with at least `@param` and `@return`/`@throws`. Please add doc comments to both methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
