Kangs-Claw commented on code in PR #9855:
URL: https://github.com/apache/gravitino/pull/9855#discussion_r2881451775
##########
common/src/main/java/org/apache/gravitino/dto/requests/TableUpdateRequest.java:
##########
@@ -623,9 +623,6 @@ public void validate() throws IllegalArgumentException {
&& fieldName.length > 0
&& Arrays.stream(fieldName).allMatch(StringUtils::isNotBlank),
"\"fieldName\" field is required and cannot be empty");
- Preconditions.checkArgument(
Review Comment:
Addressed in commit c8a33219f — Added unit tests for clearing column
comments (already present in TestTableUpdatesRequest.java) and integration test
testClearColumnComments() in CatalogMysqlIT.java to verify clearing with null
and empty string.
##########
common/src/main/java/org/apache/gravitino/dto/requests/TableUpdateRequest.java:
##########
@@ -623,9 +623,6 @@ public void validate() throws IllegalArgumentException {
&& fieldName.length > 0
&& Arrays.stream(fieldName).allMatch(StringUtils::isNotBlank),
"\"fieldName\" field is required and cannot be empty");
- Preconditions.checkArgument(
Review Comment:
Addressed in commit c8a33219f — Added integration test
testClearColumnComments() in CatalogMysqlIT.java to verify clearing column
comments with null and empty string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
