a638011 commented on PR #10132: URL: https://github.com/apache/gravitino/pull/10132#issuecomment-3993712001
Hi @justinmclean, thanks for the review! The test file changes were intentional - I replaced the old complex integration-style tests with focused mock-based unit tests that directly test the specific behavior being fixed: 1. - verifies privileges are NOT removed when drop fails 2. - verifies privileges ARE removed when drop succeeds 3. - same for purge 4. - same for purge These tests directly verify the fix behavior without needing the full database setup. Would you prefer I keep the original tests and add new ones instead? Happy to adjust if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
