FANNG1 commented on PR #10110:
URL: https://github.com/apache/gravitino/pull/10110#issuecomment-3989959617

   
   > **1. Timestamp Handling in `Updater.java`** In `Updater.java`, methods 
`collectTableMetrics` (line 303), `collectPartitionMetrics` (line 321), and 
`collectJobMetrics` (line 333) use `System.currentTimeMillis()` for the metric 
timestamp:
   
   will be handled in https://github.com/apache/gravitino/pull/10138
   
    **2. Dropping Non-Numeric Statistics in `AbstractStatisticsImporter.java`** 
In `AbstractStatisticsImporter.java` (line 523), non-numeric values are 
explicitly dropped:
   
   I prefer not handle non-numeric values as this will the logic complex,  as 
the formatted is defined by Gravitino, the provider could follow the format to 
avoid exception.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to