yuqi1129 commented on code in PR #9927:
URL: https://github.com/apache/gravitino/pull/9927#discussion_r2851844841
##########
common/src/main/java/org/apache/gravitino/json/JsonUtils.java:
##########
@@ -1473,14 +1474,18 @@ public void serialize(Index value, JsonGenerator gen,
SerializerProvider seriali
}
gen.writeFieldName(INDEX_FIELD_NAMES);
gen.writeObject(value.fieldNames());
+ Map<String, String> props = value.properties();
+ gen.writeFieldName("properties");
+ Map<String, String> sortedProps = new java.util.TreeMap<>(props);
Review Comment:
java.util.
##########
common/src/main/java/org/apache/gravitino/dto/requests/TableUpdateRequest.java:
##########
@@ -821,7 +822,7 @@ public AddTableIndexRequest() {}
* @param fieldNames The field names under the table contained in the
index.
*/
public AddTableIndexRequest(Index.IndexType type, String name, String[][]
fieldNames) {
- this.index = Indexes.of(type, name, fieldNames);
+ this.index = Indexes.of(type, name, fieldNames, Map.of());
}
Review Comment:
<img width="819" height="177" alt="Image"
src="https://github.com/user-attachments/assets/f6626b8f-191a-4348-8785-85cbabba0427";
/>
Since you have added this method, there is no need to make a change here.
##########
docs/jdbc-doris-catalog.md:
##########
@@ -171,7 +171,7 @@ Unsupported for now.
```java
Index[] indexes = new Index[] {
- Indexes.of(IndexType.PRIMARY_KEY, "PRIMARY", new String[][]{{"id"}})
+ Indexes.of(IndexType.PRIMARY_KEY, "PRIMARY", new String[][]{{"id"}},
Map.of())
Review Comment:
Can you take the time to remove all unnecessary change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
