diqiu50 commented on code in PR #8777:
URL: https://github.com/apache/gravitino/pull/8777#discussion_r2508578566


##########
clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/GravitinoVirtualFileSystemUtils.java:
##########
@@ -61,7 +61,16 @@ public static Map<String, String> getConfigMap(Configuration 
configuration) {
     Map<String, String> maps = Maps.newHashMap();
     // Don't use entry.getKey() directly in the lambda, because it cannot
     // handle variable expansion in the Configuration values.
-    configuration.forEach(entry -> maps.put(entry.getKey(), 
configuration.get(entry.getKey())));
+    Configuration defaultConf = new Configuration();
+    configuration.forEach(

Review Comment:
   I think the correct behavior of this method is to retrieve the set 
properties, rather than fetching all the default properties.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to