jerryshao commented on code in PR #8879:
URL: https://github.com/apache/gravitino/pull/8879#discussion_r2459087467
##########
api/src/main/java/org/apache/gravitino/rel/indexes/Indexes.java:
##########
@@ -73,10 +89,81 @@ public static Index of(Index.IndexType indexType, String
name, String[][] fieldN
.build();
}
+ /** Custom JSON serializer for Index objects. */
Review Comment:
It's not proper to add the JSON serde in the API module. Should if be in the
class like `IndexDTO`, and then convert the `IndexDTO` to the IndexImpl here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
