(gravitino) branch main updated: [MINOR] test: Add validation tests for X-Iceberg-Access-Delegation header (#8885)

[fanng]

This is an automated email from the ASF dual-hosted git repository.

fanng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/main by this push:
     new 09a248de13 [MINOR] test:  Add validation tests for 
X-Iceberg-Access-Delegation header (#8885)
09a248de13 is described below

commit 09a248de13eaa7c25384bbdb2e2d8e1ea9f23fb2
Author: Bharath Krishna <bmur...@roku.com>
AuthorDate: Thu Oct 23 01:08:11 2025 -0700

    [MINOR] test:  Add validation tests for X-Iceberg-Access-Delegation header 
(#8885)
    
    ### What changes were proposed in this pull request?
    Add two new test cases to validate error handling for the
    X-Iceberg-Access-Delegation header in the Iceberg REST API:
    
    - testRemoteSigningNotSupported: Validates that remote-signing access
    delegation returns 406 Not Acceptable since it's not currently supported
    by Gravitino
    
    - testInvalidAccessDelegation: Validates that invalid access delegation
    values return 400 Bad Request with appropriate error messaging
    
    These tests cover previously untested error paths in the
    isCredentialVending() validation method
    
    ### Why are the changes needed?
    Add unit tests
    
    ### Does this PR introduce _any_ user-facing change?
    No
    
    ### How was this patch tested?
    Unit tests
---
 .../service/rest/TestIcebergTableOperations.java   | 50 ++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git 
a/iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/TestIcebergTableOperations.java
 
b/iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/TestIcebergTableOperations.java
index 28d45d4019..0705fc66fd 100644
--- 
a/iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/TestIcebergTableOperations.java
+++ 
b/iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/TestIcebergTableOperations.java
@@ -496,4 +496,54 @@ public class TestIcebergTableOperations extends 
IcebergNamespaceTestBase {
   private Response doGetTableCredentials(Namespace ns, String tableName) {
     return getTableClientBuilder(ns, Optional.of(tableName + 
"/credentials")).get();
   }
+
+  @ParameterizedTest
+  
@MethodSource("org.apache.gravitino.iceberg.service.rest.IcebergRestTestUtil#testNamespaces")
+  void testRemoteSigningNotSupported(Namespace namespace) {
+    verifyCreateNamespaceSucc(namespace);
+
+    // Attempt to create table with "remote-signing" access delegation
+    // This should fail with UnsupportedOperationException -> 406 Not 
Acceptable
+    CreateTableRequest createTableRequest =
+        CreateTableRequest.builder()
+            .withName("test_remote_signing")
+            .withSchema(tableSchema)
+            .build();
+
+    Response response =
+        getTableClientBuilder(namespace, Optional.empty())
+            .header(IcebergTableOperations.X_ICEBERG_ACCESS_DELEGATION, 
"remote-signing")
+            .post(Entity.entity(createTableRequest, 
MediaType.APPLICATION_JSON_TYPE));
+
+    Assertions.assertEquals(406, response.getStatus());
+    String errorBody = response.readEntity(String.class);
+    Assertions.assertTrue(
+        errorBody.contains("remote signing") || 
errorBody.contains("remote-signing"),
+        "Error message should mention remote signing: " + errorBody);
+  }
+
+  @ParameterizedTest
+  
@MethodSource("org.apache.gravitino.iceberg.service.rest.IcebergRestTestUtil#testNamespaces")
+  void testInvalidAccessDelegation(Namespace namespace) {
+    verifyCreateNamespaceSucc(namespace);
+
+    // Attempt to create table with invalid access delegation value
+    // This should fail with IllegalArgumentException -> 400 Bad Request
+    CreateTableRequest createTableRequest =
+        CreateTableRequest.builder()
+            .withName("test_invalid_delegation")
+            .withSchema(tableSchema)
+            .build();
+
+    Response response =
+        getTableClientBuilder(namespace, Optional.empty())
+            .header(IcebergTableOperations.X_ICEBERG_ACCESS_DELEGATION, 
"invalid-value")
+            .post(Entity.entity(createTableRequest, 
MediaType.APPLICATION_JSON_TYPE));
+
+    Assertions.assertEquals(400, response.getStatus());
+    String errorBody = response.readEntity(String.class);
+    Assertions.assertTrue(
+        errorBody.contains("vended-credentials") && 
errorBody.contains("illegal"),
+        "Error message should mention valid values: " + errorBody);
+  }
 }