This is an automated email from the ASF dual-hosted git repository.
jshao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new eaee6534ac [#8663] Add a precondition to check updates is not null in
FilesetUpdatesRequest.java and a unit test (#8760)
eaee6534ac is described below
commit eaee6534acd7c625c6a10c30f719e8169196fcb7
Author: Pratyush Kumar <[email protected]>
AuthorDate: Mon Oct 13 04:25:44 2025 -0700
[#8663] Add a precondition to check updates is not null in
FilesetUpdatesRequest.java and a unit test (#8760)
### What changes were proposed in this pull request?
I have added code to check that updates is not null in
`common/src/main/java/org/apache/gravitino/dto/requests/FilesetUpdatesRequest.java`
to avoid a `NullPointerException`. Additionally a unit test (in
`common/src/test/java/org/apache/gravitino/dto/requests/TestFilesetUpdatesRequest.java`)
to test the updates has been added.
### Why are the changes needed?
Fix: #8663
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
I have tested the updates through the added unit test by running
`./gradlew :common:test --tests
"org.apache.gravitino.dto.requests.TestFilesetUpdatesRequest"` in my
computer. The test completes and I get a `BUILD SUCCESSFUL` message.
---
.../dto/requests/FilesetUpdatesRequest.java | 3 ++
.../dto/requests/TestFilesetUpdatesRequest.java | 45 ++++++++++++++++++++++
2 files changed, 48 insertions(+)
diff --git
a/common/src/main/java/org/apache/gravitino/dto/requests/FilesetUpdatesRequest.java
b/common/src/main/java/org/apache/gravitino/dto/requests/FilesetUpdatesRequest.java
index 1ab5d4a4ef..725744cd50 100644
---
a/common/src/main/java/org/apache/gravitino/dto/requests/FilesetUpdatesRequest.java
+++
b/common/src/main/java/org/apache/gravitino/dto/requests/FilesetUpdatesRequest.java
@@ -41,6 +41,9 @@ public class FilesetUpdatesRequest implements RESTRequest {
@Override
public void validate() throws IllegalArgumentException {
+ if (updates == null) {
+ throw new IllegalArgumentException("Updates list cannot be null");
+ }
updates.forEach(RESTMessage::validate);
}
}
diff --git
a/common/src/test/java/org/apache/gravitino/dto/requests/TestFilesetUpdatesRequest.java
b/common/src/test/java/org/apache/gravitino/dto/requests/TestFilesetUpdatesRequest.java
new file mode 100644
index 0000000000..92283aceca
--- /dev/null
+++
b/common/src/test/java/org/apache/gravitino/dto/requests/TestFilesetUpdatesRequest.java
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.gravitino.dto.requests;
+
+import java.util.Collections;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+public class TestFilesetUpdatesRequest {
+
+ @Test
+ public void testValidateWithNullUpdates() {
+ // Test that creating a request with null updates throws an exception
during validation
+ FilesetUpdatesRequest request = new FilesetUpdatesRequest(null);
+
+ final IllegalArgumentException exception =
+ Assertions.assertThrows(IllegalArgumentException.class,
request::validate);
+
+ Assertions.assertEquals("Updates list cannot be null",
exception.getMessage());
+ }
+
+ @Test
+ public void testValidateWithEmptyUpdates() {
+ // Test that a non-null but empty list of updates is valid
+ FilesetUpdatesRequest request = new
FilesetUpdatesRequest(Collections.emptyList());
+
+ Assertions.assertDoesNotThrow(request::validate);
+ }
+}
