This is an automated email from the ASF dual-hosted git repository.

jshao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/main by this push:
     new a695f57a31 [#8694] fix(ui): reconfigure submit parameters for creating 
catalog (#8714)
a695f57a31 is described below

commit a695f57a312c26e58874a910405ce6c171e20ce1
Author: Qian Xia <[email protected]>
AuthorDate: Mon Sep 29 14:03:25 2025 +0800

    [#8694] fix(ui): reconfigure submit parameters for creating catalog (#8714)
    
    ### What changes were proposed in this pull request?
    reconfigure submit parameters for creating catalog
    <img width="1664" height="695" alt="image"
    
src="https://github.com/user-attachments/assets/b2dab7fd-cb8d-41fb-8f0d-bd4c56fc84a4";
    />
    
    
    ### Why are the changes needed?
    should pass the warehouse properties when creating Iceberg catalog with
    JDBC backend
    
    Fix: #8694
    
    ### Does this PR introduce _any_ user-facing change?
    N/A
    
    ### How was this patch tested?
    manually
---
 .../metalake/rightContent/CreateCatalogDialog.js   | 34 +++++-----------------
 1 file changed, 7 insertions(+), 27 deletions(-)

diff --git 
a/web/web/src/app/metalakes/metalake/rightContent/CreateCatalogDialog.js 
b/web/web/src/app/metalakes/metalake/rightContent/CreateCatalogDialog.js
index e86dd66110..68504aa172 100644
--- a/web/web/src/app/metalakes/metalake/rightContent/CreateCatalogDialog.js
+++ b/web/web/src/app/metalakes/metalake/rightContent/CreateCatalogDialog.js
@@ -278,33 +278,13 @@ const CreateCatalogDialog = props => {
           ...others
         } = prevProperties
 
-        if (
-          catalogBackend &&
-          ['rest', 'hive'].includes(catalogBackend) &&
-          ['lakehouse-iceberg', 'lakehouse-paimon'].includes(providerSelect)
-        ) {
-          properties = {
-            'catalog-backend': catalogBackend,
-            uri: uri,
-            ...others
-          }
-          warehouse && (properties['warehouse'] = warehouse)
-        } else if (catalogBackend && catalogBackend === 'filesystem' && 
providerSelect === 'lakehouse-paimon') {
-          properties = {
-            'catalog-backend': catalogBackend,
-            ...others
-          }
-          uri && (properties['uri'] = uri)
-        } else {
-          properties = {
-            uri: uri,
-            ...others
-          }
-          catalogBackend && (properties['catalog-backend'] = catalogBackend)
-          jdbcDriver && (properties['jdbc-driver'] = jdbcDriver)
-          jdbcUser && (properties['jdbc-user'] = jdbcUser)
-          jdbcPwd && (properties['jdbc-password'] = jdbcPwd)
-        }
+        properties = { ...others }
+        catalogBackend && (properties['catalog-backend'] = catalogBackend)
+        uri && (properties['uri'] = uri)
+        warehouse && (properties['warehouse'] = warehouse)
+        jdbcDriver && (properties['jdbc-driver'] = jdbcDriver)
+        jdbcUser && (properties['jdbc-user'] = jdbcUser)
+        jdbcPwd && (properties['jdbc-password'] = jdbcPwd)
         authType && (properties['authentication.type'] = authType)
         kerberosPrincipal && (properties['authentication.kerberos.principal'] 
= kerberosPrincipal)
         kerberosKeytabUri && (properties['authentication.kerberos.keytab-uri'] 
= kerberosKeytabUri)

Reply via email to