yuqi1129 commented on code in PR #8675:
URL: https://github.com/apache/gravitino/pull/8675#discussion_r2384709016
##########
scripts/h2/upgrade-0.9.0-to-1.0.0-h2.sql:
##########
@@ -67,50 +67,50 @@ ALTER TABLE `model_version_info` ADD CONSTRAINT
`uk_mid_ver_uri_del` UNIQUE (`mo
ALTER TABLE `model_version_info` ALTER COLUMN `model_version_uri_name` DROP
DEFAULT;
CREATE TABLE IF NOT EXISTS `statistic_meta` (
- `id` BIGINT(20) UNSIGNED NOT NULL AUTO_INCREMENT COMMENT 'auto increment
id',
- `statistic_id` BIGINT(20) UNSIGNED NOT NULL COMMENT 'statistic id',
+ `id` BIGINT NOT NULL AUTO_INCREMENT COMMENT 'auto increment id',
+ `statistic_id` BIGINT NOT NULL COMMENT 'statistic id',
`statistic_name` VARCHAR(128) NOT NULL COMMENT 'statistic name',
- `metalake_id` BIGINT(20) UNSIGNED NOT NULL COMMENT 'metalake id',
- `statistic_value` MEDIUMTEXT NOT NULL COMMENT 'statistic value',
- `metadata_object_id` BIGINT(20) UNSIGNED NOT NULL COMMENT 'metadata object
id',
+ `metalake_id` BIGINT NOT NULL COMMENT 'metalake id',
+ `statistic_value` CLOB NOT NULL COMMENT 'statistic value',
+ `metadata_object_id` BIGINT NOT NULL COMMENT 'metadata object id',
`metadata_object_type` VARCHAR(64) NOT NULL COMMENT 'metadata object type',
- `audit_info` MEDIUMTEXT NOT NULL COMMENT 'statistic audit info',
- `current_version` INT UNSIGNED NOT NULL DEFAULT 1 COMMENT 'statistic
current version',
- `last_version` INT UNSIGNED NOT NULL DEFAULT 1 COMMENT 'statistic last
version',
- `deleted_at` BIGINT(20) UNSIGNED NOT NULL DEFAULT 0 COMMENT 'statistic
deleted at',
+ `audit_info` CLOB NOT NULL COMMENT 'statistic audit info',
+ `current_version` INT NOT NULL DEFAULT 1 COMMENT 'statistic current
version',
+ `last_version` INT NOT NULL DEFAULT 1 COMMENT 'statistic last version',
+ `deleted_at` BIGINT NOT NULL DEFAULT 0 COMMENT 'statistic deleted at',
PRIMARY KEY (`id`),
UNIQUE KEY `uk_si_mi_mo_del` (`statistic_name`, `metadata_object_id`,
`deleted_at`),
KEY `idx_stid` (`statistic_id`),
KEY `idx_moid` (`metadata_object_id`)
-) ENGINE=InnoDB;
+);
CREATE TABLE IF NOT EXISTS `job_template_meta` (
- `job_template_id` BIGINT(20) UNSIGNED NOT NULL COMMENT 'job template id',
+ `job_template_id` BIGINT NOT NULL COMMENT 'job template id',
`job_template_name` VARCHAR(128) NOT NULL COMMENT 'job template name',
- `metalake_id` BIGINT(20) UNSIGNED NOT NULL COMMENT 'metalake id',
- `job_template_comment` TEXT DEFAULT NULL COMMENT 'job template comment',
- `job_template_content` MEDIUMTEXT NOT NULL COMMENT 'job template content',
- `audit_info` MEDIUMTEXT NOT NULL COMMENT 'job template audit info',
- `current_version` INT UNSIGNED NOT NULL DEFAULT 1 COMMENT 'job template
current version',
- `last_version` INT UNSIGNED NOT NULL DEFAULT 1 COMMENT 'job template last
version',
- `deleted_at` BIGINT(20) UNSIGNED NOT NULL DEFAULT 0 COMMENT 'job template
deleted at',
+ `metalake_id` BIGINT NOT NULL COMMENT 'metalake id',
+ `job_template_comment` CLOB DEFAULT NULL COMMENT 'job template comment',
+ `job_template_content` CLOB NOT NULL COMMENT 'job template content',
+ `audit_info` CLOB NOT NULL COMMENT 'job template audit info',
+ `current_version` INT NOT NULL DEFAULT 1 COMMENT 'job template current
version',
+ `last_version` INT NOT NULL DEFAULT 1 COMMENT 'job template last version',
+ `deleted_at` BIGINT NOT NULL DEFAULT 0 COMMENT 'job template deleted at',
PRIMARY KEY (`job_template_id`),
UNIQUE KEY `uk_mid_jtn_del` (`metalake_id`, `job_template_name`,
`deleted_at`)
-) ENGINE=InnoDB;
+);
CREATE TABLE IF NOT EXISTS `job_run_meta` (
- `job_run_id` BIGINT(20) UNSIGNED NOT NULL COMMENT 'job run id',
- `job_template_id` BIGINT(20) UNSIGNED NOT NULL COMMENT 'job template id',
- `metalake_id` BIGINT(20) UNSIGNED NOT NULL COMMENT 'metalake id',
- `job_execution_id` varchar(256) NOT NULL COMMENT 'job execution id',
- `job_run_status` varchar(64) NOT NULL COMMENT 'job run status',
- `job_finished_at` BIGINT(20) UNSIGNED NOT NULL DEFAULT 0 COMMENT 'job
finished at',
- `audit_info` MEDIUMTEXT NOT NULL COMMENT 'job run audit info',
- `current_version` INT UNSIGNED NOT NULL DEFAULT 1 COMMENT 'job run current
version',
- `last_version` INT UNSIGNED NOT NULL DEFAULT 1 COMMENT 'job run last
version',
- `deleted_at` BIGINT(20) UNSIGNED NOT NULL DEFAULT 0 COMMENT 'job run
deleted at',
+ `job_run_id` BIGINT NOT NULL COMMENT 'job run id',
Review Comment:
Why do you choose separate SQL sentences to add comments for table columns
in `schema-0.6.0-h2.sql` but use MySQL-sytle column comment format here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
