keepConcentration commented on code in PR #8695:
URL: https://github.com/apache/gravitino/pull/8695#discussion_r2381190680
##########
core/src/main/java/org/apache/gravitino/cache/CaffeineEntityCache.java:
##########
@@ -303,8 +303,6 @@ protected void invalidateExpiredItem(EntityCacheKey key) {
* @param newEntities The new entities to sync to the cache.
*/
private void syncEntitiesToCache(EntityCacheRelationKey key, List<Entity>
newEntities) {
- if (key.relationType() != null) return;
Review Comment:
Hi @yuqi1129, thanks for the review.
Looking at PR #8297 where this code was introduced, it seems the original
intention was to cache relational data. However, the `if (key.relationType() !=
null) return;` line appears to prevent this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
