FANNG1 commented on code in PR #8592:
URL: https://github.com/apache/gravitino/pull/8592#discussion_r2366560693
##########
common/src/main/java/org/apache/gravitino/credential/CredentialPropertyUtils.java:
##########
@@ -46,6 +46,20 @@ public class CredentialPropertyUtils {
@VisibleForTesting
static final String ICEBERG_ADLS_ACCOUNT_KEY =
"adls.auth.shared-key.account.key";
+ // Map from credential types to their corresponding storage system prefixes
+ // Only includes the types supported by toIcebergProperties method
+ private static final Map<Class<? extends Credential>, String>
CREDENTIAL_TYPE_TO_PREFIX_MAP =
Review Comment:
From personal perspective, I prefer to ignore `prefix` properties, because
Gravitino doesn't support generate different credential for different locations
yet, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
