Abyss-lord commented on code in PR #8516:
URL: https://github.com/apache/gravitino/pull/8516#discussion_r2338334838
##########
core/src/main/java/org/apache/gravitino/listener/api/event/ListTopicFailureEvent.java:
##########
@@ -39,7 +41,8 @@ public final class ListTopicFailureEvent extends
TopicFailureEvent {
* @param exception The exception encountered during the attempt to list
topics.
*/
public ListTopicFailureEvent(String user, Namespace namespace, Exception
exception) {
Review Comment:
I suggest adding a new static factory method to NameIdentifier, for example:
```java
public static NameIdentifier of(Namespace namespace) {
check(namespace != null, "Cannot create a NameIdentifier with null
namespace");
return of(namespace.levels());
}
```
This way, `ListTopicFailureEvent` can remain unchanged. WDYT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
