Abyss-lord commented on code in PR #8405:
URL: https://github.com/apache/gravitino/pull/8405#discussion_r2332102911
##########
common/src/main/java/org/apache/gravitino/utils/JdbcUrlUtils.java:
##########
@@ -68,18 +69,19 @@ private JdbcUrlUtils() {
* @param all the JDBC configuration properties
*/
public static void validateJdbcConfig(String driver, String url, Map<String,
String> all) {
+ Preconditions.checkArgument(driver != null, "Driver class name cannot be
null");
Review Comment:
@yuqi1129 I think it’s better to use `StringUtils.isBlank()` instead of
`StringUtils.isNotEmpty()`. The latter only checks for null or zero-length
strings, while in this case we need to ensure that both `driver` and `url` are
not blank (i.e., not null, not empty, and not just whitespace).
<img width="498" height="106" alt="image"
src="https://github.com/user-attachments/assets/ecffc45d-519e-4f4f-947a-87ca856857f0";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
