mchades commented on PR #8406: URL: https://github.com/apache/gravitino/pull/8406#issuecomment-3247964067
> I don't know why this is not reflected by test before The method `insertPolicyMetaOnDuplicateKeyUpdate` is only called when using an insert policy with `overwritten=true`, but currently, no one is using it—alter policy uses the `updatePolicyMeta` method instead. Therefore, the bug cannot be detected yet. > Besides, I think we need a test to cover this. Since the policy has no operation to trigger the case, the policyIT cannot cover it. By default, the Mapper's UT only tests H2. To make the Mapper UT cover different backend storages, this should be done in a separate PR. So, the current fix looks good to me. @Ashwil-Colaco, please update the PR title to follow the correct template. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
