jerqi commented on code in PR #8297:
URL: https://github.com/apache/gravitino/pull/8297#discussion_r2306464037
##########
core/src/main/java/org/apache/gravitino/authorization/PermissionManager.java:
##########
@@ -80,6 +80,7 @@ User grantRolesToUser(String metalake, List<String> roles,
String user) {
AuthorizationUtils.ofUser(metalake, user),
UserEntity.class,
Entity.EntityType.USER,
+ roles,
userEntity -> {
List<RoleEntity> roleEntities = Lists.newArrayList();
Review Comment:
Another point, this will execute cache operation multiple times. It's not
an atomic operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
