yuqi1129 commented on code in PR #8252:
URL: https://github.com/apache/gravitino/pull/8252#discussion_r2300716465


##########
core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java:
##########


Review Comment:
   If the comment I posted wasn't clear enough, I can't provide any evidence 
that is more persuasive. it can be summarized as 'Catalog related thread locals 
are initialized in jetty thread pool and then closed with Caffeine thread pool'
   
   ```text
         // Clear thread local map for webserver threads in the current class 
loader. Why do we need
         // this? Because the webserver threads are long-lived threads and will 
holds may thread
         // local references to the current class loader. However, they can't 
be cleared as
         // `Catalog.close` is called in the thread pool located in the 
Caffeine cache, which is not
         // in the webserver threads. So we need to manually clear the thread 
local map for webserver
         // threads.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to