hqbhoho commented on code in PR #8188:
URL: https://github.com/apache/gravitino/pull/8188#discussion_r2299578191
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/hive/HiveMetadataAdapter.java:
##########
@@ -249,4 +251,14 @@ public ConnectorTableMetadata
getTableMetadata(GravitinoTable gravitinoTable) {
properties,
Optional.ofNullable(gravitinoTable.getComment()));
}
+
+ /**
+ * Get the column handle name that will generate row IDs for the merge
operation.
+ *
+ * @return the column handle name for row IDs
+ */
+ @Override
+ public String getMergeRowIdColumnHandleName() {
+ return MERGE_ROW_ID;
Review Comment:
In this PR, it is not need implement for Hive and Iceberg.
However, in a subsequent PR(#8258), we will support UPDATE/DELETE/MERGE
operations for Hive and Iceberg.
So I implemented these two methods here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
