yuqi1129 commented on code in PR #8139: URL: https://github.com/apache/gravitino/pull/8139#discussion_r2299527568
########## docs/gravitino-mcp-server.md: ########## @@ -51,6 +51,10 @@ Or start a HTTP MCP server by `uv run mcp_server --metalake test --uri http://12 } ``` +### Docker instructions + +You could start Gravitino MCP server by docker images, `docker run -p 1234:1234 apache/gravitino-mcp-server:latest --metalake test --transport http --mcp-url http://0.0.0.0:8000/mcp`. Please note that the MCP server in docker container doesn't support `stdio` transport mode. Review Comment: docker images -> docker image. ########## dev/docker/mcp-server/mcp-server-dependency.sh: ########## @@ -0,0 +1,33 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +set -ex +mcp_server_dir="$(dirname "${BASH_SOURCE-$0}")" +mcp_server_dir="$(cd "${mcp_server_dir}">/dev/null; pwd)" +gravitino_home="$(cd "${mcp_server_dir}/../../..">/dev/null; pwd)" + +# Prepare the Iceberg REST server packages Review Comment: This line is incorrect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
